Update to @haverstack/core 0.8.0, simplify attachment routes#30
Merged
Conversation
Bump @haverstack/core dependency to 0.7.0 and simplify the GET and DELETE attachment routes to delegate to the new Stack/ScopedStack methods instead of reimplementing the access control and cleanup logic inline. - GET /attachments/:fileId now uses ScopedStack.getAttachment(), removing the standalone isAttachmentAccessible helper (~30 lines) - DELETE /attachments/:fileId now uses Stack.deleteAttachment(), collapsing ~20 lines of query/check/loop logic into a single call - Add StackConflictError → 409 to the error middleware Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Picks up the StackConflictError public export fix. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@haverstack/coreto^0.8.0(addsgetAttachment/deleteAttachmenttoStackClient,Stack, andScopedStack; exportsStackConflictError)StackConflictError→ 409 to the error middlewareRoute changes
GET
/attachments/:fileId— replaces the standaloneisAttachmentAccessiblehelper (~30 lines) with a singleScopedStack.getAttachment()call. Access control logic (owner / referencing record / uploader) now lives in core.DELETE
/attachments/:fileId— replaces the manual meta-record query, reference check, hard-delete loop, and adapter call (~20 lines) with a singlestack.deleteAttachment()call.StackNotFoundErrorandStackConflictErrorbubble up to the error middleware.POST
/attachments— unchanged; still callsadapter.putAttachment()directly for the raw byte upload.Test plan
🤖 Generated with Claude Code
https://claude.ai/code/session_01PrLzbXMVj16yzEH6SjJkhA
Generated by Claude Code